https://bugzilla.wikimedia.org/show_bug.cgi?id=31656
Web browser: ---
Bug #: 31656
Summary: AbuseFilter should extract old_wikitext from the last
revision, not from the edited revision
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: AbuseFilter
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
Classification: Unclassified
Hello,
When an old revision of a page is selected in the history, edited and
published, it seems that AbuseFilter initializes old_wikitext with the text of
this old revision instead of the last published revision before the current
edit (this also affects related variables such as added_lines).
Moreover, when an old revision is edited and published without any change, the
edit is not filtered at all (because of the test "if ( strcmp( $oldtext, $text
) == 0 ) ... return true;" in the function onEditFilterMerged of
AbuseFilter.hooks.php, I guess).
This makes possible to circumvent any filter as soon as a "bad" revision exists
in the page history. Moreover, it is hard to understand afterwards why such
edits are not filtered, as they trigger filters normally in the test interface.
Best regards
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
