https://bugzilla.wikimedia.org/show_bug.cgi?id=31723
--- Comment #3 from Bryan Tong Minh <[email protected]> 2011-10-15 10:12:14 UTC --- (In reply to comment #2) > Hm, I don't duplicate existing CheckUser functions. Only two functions taken > from main CheckUser class. > With code duplication I mean copy-pasting of functions. My point is that by doing all the backend work in different places for the UI and API, it is easy for those code paths to diverge, which is an increased in maintenance burden, and is a potential risk for future security problems. There are numerous essays on the web that do a better job in explaining why copy-pasting code is bad than me. See for example [1], under the heading "Why is code duplication bad?" [1] http://www.solidsourceit.com/blog/?p=4 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
