https://bugzilla.wikimedia.org/show_bug.cgi?id=31484

--- Comment #12 from Brion Vibber <[email protected]> 2011-10-25 20:21:29 UTC 
---
So the ultimate confusion with all this is that as far as we can tell, long
touch to activate text selection mode *is baked in to the WebView* and should
already work, without us doing anything at all special.

I've checked out the Android 2.3.6r1 source and packaged it up for Eclipse (per
<http://android.opensourceror.org/2010/01/18/android-source/>) so I could step
through the code and see what's going on.

(Note: I had to remove a directory tree containing 'mock' interfaces so the
real code would show up in Eclipse when debugging.)

WebView.performLongClick() gets called when I've been holding on the screen for
half a second or so.

This function does some checks (all of which pass), including a call to
super.performLongClick() which should call any standard event handlers or
context menu popups that are attached. This doesn't actually trigger anything,
so we keep on executing.

It then starts the text selection by calling its own WebView.setUpSelect()
function (the same function that emulateLeftShiftClick() calls) and if I
understand then attempts to adjust the selection to match the word you were
clicking on.

Finally, it calls notifySelectDialogDismissed() and returns false to continue
on to other things.


So it *really looks like* it's setting up text selection.... but it doesn't
appear to actually happen. What the heck? A minimal test case might be nice
here.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to