https://bugzilla.wikimedia.org/show_bug.cgi?id=6793

--- Comment #8 from [email protected] 2011-10-26 20:21:06 UTC ---
I swear it didn't work... someone must've turned on forwarding.

Anyway, do you think it would be a good idea to change the parameters, or is it
okay like this? Right now it's a bit illogical IMHO, $oldtext is the text of
the page before the edit, $text is the text of the new section (i.e. the
contents of the edit box), and the hook expects you to put the new, merged text
into $text, since that's how the core code works; but it would make more sense
to have a &$text that contains the old text, a $subject and a $sectiontext, and
then you'd have to replace $text with the merged version. That would make more
sense since you're changing the page text, not the text of the new section, but
would require some additional code to put everything where it's supposed to go
before and after calling the hook.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to