| daniel added a comment. |
@Lucas_Werkmeister_WMDE The rationale for changing code to use narrow interfaces where possible is top remove circular dependencies to enable modularization. Currently, MW core is a tight knot of cross-dependencies, and kitchen sinks like IContextSource and "smart" records like User and Title are the main reason for that.
So, changing from IContextSource to MessageLocalizer contributes general code hygiene. The advantage is mid-term improvements of code quality.
@Ladsgroup: I don't see a need for RequestBasedMessageLocalizer. It's fine to use a RequestContext as the concrete instance, the code just shouldn't bind to that class (or the IContextSource) any more. RequestContext can be deprecated and replaced when nothing hints against it any more.
Cc: daniel, Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, abian, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
