[Wikidata-bugs] [Maniphest] [Created] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

Mon, 26 Feb 2018 12:32:48 -0800

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikimedia-Incident.
Herald added a subscriber: Aklapper.

TASK DESCRIPTION

WikiPageEntityMetaDataLookup::getWhere has a special guard against an empty condition list for the query:

		if ( empty( $where ) ) {
			// If we skipped all entity IDs, select nothing, not everything.
			return '0';
		}


However, Database::selectSQLText actually interprets that '0' as “no conditions” (same as []), which results in a query without WHERE clause. Make sure we return something better. ([ false ]?)

TASK DETAIL
https://phabricator.wikimedia.org/T188313

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg, mmodell
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to