| Legoktm added a comment. |
In T188354#4010463, @thiemowmde wrote:When an extension does not work without mediawiki/core […] When it works without core […]
I'm afraid I did not made my point clear enough. This is not an "either-or" thing. The code bases I talk about are extensions, but contain code that is intentionally independent from MediaWiki core. The teams wish to run these tests independently from core is nothing that is set in stone, and will totally be disputed and changed the moment it creates actual problems. I just want us to a) have a migration path first, and b) let the responsible teams decide before removing code that currently does no actual harm.
I understand the advantage of keeping the tests separate on the filesystem, but I don't really see much substantial benefit from *running* them separately. We're already running them as part of MediaWiki test suite anyways.
This ticket is about the actual problem it's creating...it's preventing us from upgrading to PHPUnit 6, and will continue to cause problems as we increase the PHPUnit version we use.
MediaWiki is going to provide a forwards and backwards-compatibility layer for […] dual support […]
Thats awesome! Thank you. Will this be provided via \MediaWikiTestCase only, or also work for tests that directly extend \PHPUnit\Framework\TestCase?
getMock()/setExpectedException() are provided via a trait that MediaWikiTestCase will use by default, but any class can use independent of MediaWikiTestCase (similar to the MediaWikiCoversValidator trait) There's also going to be an autoloader to class_alias old non-namespaced names, which will be invoked as long as you use the MediaWiki test runner. See https://gerrit.wikimedia.org/r/#/c/394851/ for the details.
Cc: daniel, Ladsgroup, WMDE-leszek, Lydia_Pintscher, Aklapper, Umherirrender, Reedy, thiemowmde, Legoktm, Lahi, SilvioAryneutro, Gq86, Timoavax79, Cinemantique, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Darkdadaah, zeljkofilipin, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
