| Smalyshev added a comment. |
Some thoughts on the implementation:
Parameter matching seems to be backwards:
?url tabular:url 'uri' . ?type tabular:type 'string' .
If I understand it right, 'uri', 'string', 'integer' etc. are types. As such, there's a limited set of them and they should be predicates. While the column names - which are user-defined - should be strings. I.e.:
?url wikibase:csvUri "url" . ?type wikibase:csvString "type" .etc.
Not sure about using wikibase: prefix - this data is not exactly related to wikibase. Maybe some other prefix is better.
About the code:
- Not sure why it uses MultiSearchIterator - there doesn't seem to be any usage of external bindings? Unless it is allowed to use variable in binding URL? Is that necessary? I would imagine most usage would be with constant URL, am I wrong?
- Same goes for all query parameters - they are all accept bindings. Do we really need to make them all variable? Is there a use case for it?
- otQuery probably shouldn't be in generic WDQS code, so if we merge this into WDQS code, we need to see how it can be supported.
- I think the URL should be checked against whitelist.txt. We can have another whitelist but I think it'd be just complicating the matters.
- Would be nice to get it as a patch to WDQS in gerrit (sans OSM-specific code)
TASK DETAIL
EMAIL PREFERENCES
To: Smalyshev
Cc: NavinoEvans, Pasleim, Lucas_Werkmeister_WMDE, Smalyshev, Aklapper, Yurik, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, debt, Reasno, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, Base, aude, Tobias1984, Manybubbles, jayvdb, zhuyifei1999, Mbch331, Jay8g
Cc: NavinoEvans, Pasleim, Lucas_Werkmeister_WMDE, Smalyshev, Aklapper, Yurik, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, debt, Reasno, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, Base, aude, Tobias1984, Manybubbles, jayvdb, zhuyifei1999, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
