thiemowmde edited subscribers, added: WMDE-leszek; removed: Rzuwig, JanZerebecki.
thiemowmde added a comment.

Yea, there is an interface violation in WikibaseClient::getPrefetchingTermLookup as well as WikibaseRepo::getPrefetchingTermLookup. I uploaded as a reminder. For what this ticket here is about you should ignore this and the separate TermBuffer interface and only care about classes implementing PrefetchingTermLookup.

Please try to avoid fiddling with TermIndex, if possible. It is way to heavily bound to the wb_terms table. I feel it exposes to much of the wb_terms table structure, as well as details of the WHERE clause.

When looking at classes like BufferingTermLookup I have similar concerns. It is way to heavily bound to TermIndex, and not worth fiddling with.

I would recommend sticking to the PrefetchingTermLookup interface, and possibly creating a new caching layer that is different from BufferingTermLookup.

@daniel, what do you think?



To: thiemowmde
Cc: WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g, Rzuwig, JanZerebecki
Wikidata-bugs mailing list

Reply via email to