| Lucas_Werkmeister_WMDE updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
We want to declare the `wikibase.entityPage.entityLoaded`, `wikibase.statement.saved` and `wikibase.statement.removed` hooks as stable interfaces. We could do this in the same announcement as {T169770}, but I feel like that should focus more on the deprecation and migration path of `wbEntity`.
We //might// also want to amend the Stable Interface Policy to clarify that adding arguments to a hook is not a breaking change. (I have to admit, I don’t remember what the PM / Engineering Time decision on this was – were we going to do this or not?)
~~(Tangential: Perhaps we should rename the `wikibase.statement.*` hooks to `wikibase.entityPage.statement.*`, for consistency with `entityLoaded`? Now would be the time to do it, of course – //before// it’s declared stable :) )~~ After a short IRL discussion, the decision was to not do this, since the code that fires the hook has no idea that it’s on an entity page.
We //might// also want to amend the Stable Interface Policy to clarify that adding arguments to a hook is not a breaking change. (I have to admit, I don’t remember what the PM / Engineering Time decision on this was – were we going to do this or not?)
~~(Tangential: Perhaps we should rename the `wikibase.statement.*` hooks to `wikibase.entityPage.statement.*`, for consistency with `entityLoaded`? Now would be the time to do it, of course – //before// it’s declared stable :) )~~ After a short IRL discussion, the decision was to not do this, since the code that fires the hook has no idea that it’s on an entity page.
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: Lea_Lacroix_WMDE, Aleksey_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
Cc: Lea_Lacroix_WMDE, Aleksey_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
