| Jdlrobson raised the priority of this task from "High" to "Needs Triage". Jdlrobson updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
In the interim a user script has been working around this problem.
= Solution
We'd need to update the Geocrumbs extension so that it can output above the banner. It so happens that the hook that inserts the banner (onBeforePageDisplay) runs after the hook that adds the breadcrumbs (onOutputPageParserOutput).
https://github.com/wikimedia/mediawiki-extensions-GeoCrumbs/blob/master/GeoCrumbs.class.php#L78
Currently the hook makes use of sitesubtitle - it would need to be configured to instead to use
```
$out->prependHTML();
```
to append before the banner.
See:
https://github.com/wikimedia/mediawiki-extensions-WikidataPageBanner/blob/master/includes/WikidataPageBanner.hooks.php#L103
...
We could make it possible to configure the extension so that breadcrumbs can be displayed above the heading with a bit of work, but we should work out what the desired behaviour is before pushing ahead with this.In the interim a user script has been working around this problem.
= Solution
We'd need to update the Geocrumbs extension so that it can output above the banner. It so happens that the hook that inserts the banner (onBeforePageDisplay) runs after the hook that adds the breadcrumbs (onOutputPageParserOutput).
https://github.com/wikimedia/mediawiki-extensions-GeoCrumbs/blob/master/GeoCrumbs.class.php#L78
Currently the hook makes use of sitesubtitle - it would need to be configured to instead to use
```
$out->prependHTML();
```
to append before the banner.
See:
https://github.com/wikimedia/mediawiki-extensions-WikidataPageBanner/blob/master/includes/WikidataPageBanner.hooks.php#L103
TASK DETAIL
EMAIL PREFERENCES
To: Jdlrobson
Cc: TheDJ, Sjoerddebruin, Zerabat, Legoktm, Trijnstel, Jdforrester-WMF, Shanmugamp7, Stryn, Glaisher, zhuyifei1999, Moushira, Aklapper, Jdlrobson, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
Cc: TheDJ, Sjoerddebruin, Zerabat, Legoktm, Trijnstel, Jdforrester-WMF, Shanmugamp7, Stryn, Glaisher, zhuyifei1999, Moushira, Aklapper, Jdlrobson, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
