| daniel renamed this task from "Make action="" work properly with multiple slots." to "Make action="" work with multiple slots.". daniel removed a project: Epic. daniel updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
Note that it may be temporarily acceptable to only support undos that do not touch multiple slots, see T194412.
The UX for undo operations across multiple slots needs some design work.
Some considerations:
* Undo for non-textual can not use the generic edit page, and should probably not offer any free form editing ability (Wikidata has undo overwritten to behave like this). Perhaps free form efor models for which ContentHandler::supportsDirectEditing can be dropped from the undo function completelyreturns false.
* When the undo operation spans multiple slots,* Perhaps free form editing can be dropped from the undo function completely. free form editing should be disabled.If we keep it, A diff for each slot should be shown for confirmation thoughwe'll need {T174033}.
* As a baseline, undo operations could just be denied of they w* A diff for each slot should affect any slots other than the main slot.be shown for confirmation
This blocks structured data on commons, since it will be possible to trigger an undo that spans multiple slots, even though individual edits can only affect a single slot.
...
This means that the logic for undoing edits needs to be extracted from EditPage.Note that it may be temporarily acceptable to only support undos that do not touch multiple slots, see T194412.
The UX for undo operations across multiple slots needs some design work.
Some considerations:
* Undo for non-textual can not use the generic edit page, and should probably not offer any free form editing ability (Wikidata has undo overwritten to behave like this). Perhaps free form efor models for which ContentHandler::supportsDirectEditing can be dropped from the undo function completelyreturns false.
* When the undo operation spans multiple slots,* Perhaps free form editing can be dropped from the undo function completely. free form editing should be disabled.If we keep it, A diff for each slot should be shown for confirmation thoughwe'll need {T174033}.
* As a baseline, undo operations could just be denied of they w* A diff for each slot should affect any slots other than the main slot.be shown for confirmation
This blocks structured data on commons, since it will be possible to trigger an undo that spans multiple slots, even though individual edits can only affect a single slot.
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
Cc: CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
