| Tarrow created this task. Tarrow added a project: Wikibase-Containers. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. |
TASK DESCRIPTION
Currently the checkx.sh script isn't safe for use on filenames with a space (or possibly newlines). This is not of zero importance because it is run by CI jobs that can be spawned by anyone making a PR.
The currently for loop isn't recommended: see http://mywiki.wooledge.org/BashPitfalls#for_i_in_.24.28ls_.2A.mp3.29
It should be rewritten to use find -exec or xargs with the -0 option.
Acceptance Criterion
Given that file names contain spaces or newlines:
checkx.sh should test that whole file name without splitting
checkx.sh should not test a space or newline split fragment of the filename
TASK DETAIL
EMAIL PREFERENCES
To: Tarrow
Cc: Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Abbe98, Wikidata-bugs, aude, Addshore, Mbch331
Cc: Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Abbe98, Wikidata-bugs, aude, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
