[Wikidata-bugs] [Maniphest] [Reopened] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

[Jdlrobson]

Jdlrobson reopened this task as "Open". Jdlrobson added a project: RelatedArticles. Jdlrobson added a subscriber: Krinkle. Jdlrobson added a comment.

Spoke too soon. I found a page - https://fr.wikivoyage.org/wiki/Trouville-sur-Mer at resolution 2048x1536

Again, it is caused by a _javascript_ error outside the extension:

Exception in load-callback in module ext.relatedArticles.readMore:
[object Error]{description: "Object does...", message: "Object does...", name: "TypeError", number: -2146827850, stack: "TypeError: ..."}
Object doesn't support property or method 'remove'

I'm not sure why the banner code is not resilient to _javascript_ errors - but it seems any time that a _javascript_ error is thrown the following code inside the positionBanner code does not get run:

$img.load( function () {
		positionBanner( $wpbBannerImageContainer );
		$wpbBannerImageContainer.addClass( 'wpb-positioned-banner' );
	} );

@Krinkle any thoughts? I thought each module was supposed to be sandboxed?

TASK DETAIL

https://phabricator.wikimedia.org/T152185

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Winter, Lewizho99, Maathavan, Wikidata-bugs, Lydia_Pintscher

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs