Jdlrobson closed this task as "Resolved".
Jdlrobson added a comment.

Can you still reproduce a problem locally when RelatedArticles is without the above patch? If so, could you try to make a more minimal test case that ends up with e.g. putting a certain piece of code in module X that makes it fail and something in module Y, where Y won't get executed?

It looks like what's happening is WikidataPageBanner code runs and binds callback to load event; RelatedArticles throws the exception; Image loads but callback not invoked, but I have no idea how to narrow that down. I've spent a few hours now trying to work this out, but didn't get anywhere.

This bug is by fixed https://gerrit.wikimedia.org/r/437716 and I've made a follow up based on your advice - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RelatedArticles/+/437716/1/resources/ext.relatedArticles.readMore.bootstrap/index.js - let's continue the conversation about the image loading elsewhere if needed but this is low priority for web right now.


TASK DETAIL
https://phabricator.wikimedia.org/T152185

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75, Aklapper, Imarlier, Winter, Vali.matei, Wikidata-bugs, Lydia_Pintscher
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to