| hashar created this task. hashar added projects: Wikidata, Lexicographical data. |
TASK DESCRIPTION
Doing a check experimental on WikibaseLexeme triggers quibble-composer-mysql-php70-docker which fails a couple PHPUnit tests:
1) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsWithLexmesAsTargetDisplayLemma
Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "foo"))
but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "foo"))
Actual html:
<tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="" colspan="2"> </td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="" <a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2"> </td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115 gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52 gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:28 gtests/phpunit/HamcrestPHPUnitIntegration.php:31 gextensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:109 gtests/phpunit/MediaWikiTestCase.php:469 gmaintenance/doMaintenance.php:94
2) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsOnFormsTargettingFormsAreDisplayedAsLinks
Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "baz"))
but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "baz"))
Actual html:
<tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="" colspan="2"> </td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="" <a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2"> </td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:28
gtests/phpunit/HamcrestPHPUnitIntegration.php:31
gextensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:440
gtests/phpunit/MediaWikiTestCase.php:469
gmaintenance/doMaintenance.php:94Dummy change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/435980
Failed build: https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/2297/
Note in both case they show: The value's type "wikibase-entityid" does not match property's type "string".
TASK DETAIL
EMAIL PREFERENCES
To: hashar
Cc: hashar, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
Cc: hashar, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
