| Jdlrobson updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
== Thur 1st June 2018
I set it up on http://en-reading-web-staging.wmflabs.org/w/index.php?title=T173949 so I could actually debug what's going on.
Discovered the math style was added inside the [[ https://github.com/wikimedia/mediawiki-extensions-Math/blob/670f0bb8f95b8d9ac7994ab3ff45a7bb8e91d185/src/MathWikidataHook.php#L65 | Math hook ]]. I looked at what introduced this code. It was [[ https://github.com/wikimedia/mediawiki-extensions-Math/commit/946a18d14c21fff2251ec2cc5451b62e4df61276 | this patch ]] introduced by T67397.
The onWikibaseClientDataTypes hook is entered in both desktop and mobile for this article but the $dataTypeDefinitions['PT:math'] formatter-factory-callback is only entered on mobile. Why? I'm still investigating. I did a var_dump inside the format-factory-callback for some clues...
```
object(ValueFormatters\FormatterOptions)[868]
protected 'options' =>
array (size=11)
'languages' =>
object(Wikibase\LanguageFallbackChain)[834]
private 'chain' =>
array (size=1)
...
'lang' => string 'en' (length=2)
'on-error' => string 'warn' (length=4)
'unDeserializableMessage' => string 'wikibase-undeserializable-value' (length=31)
'geoformat' => string 'dms' (length=3)
'spacing' =>
array (size=1)
0 => string 'latlong' (length=7)
'directional' => boolean true
'forceSign' => boolean false
'showQuantityUncertaintyMargin' => boolean true
'applyRounding' => boolean true
'applyUnit' => boolean true
/vagrant/mediawiki/extensions/Math/src/MathWikidataHook.php:76:string 'text/plain' (length=10)
```
== Summary
...
Next step would be to replicate this on an environment where I can see exactly what's going on.== Thur 1st June 2018
I set it up on http://en-reading-web-staging.wmflabs.org/w/index.php?title=T173949 so I could actually debug what's going on.
Discovered the math style was added inside the [[ https://github.com/wikimedia/mediawiki-extensions-Math/blob/670f0bb8f95b8d9ac7994ab3ff45a7bb8e91d185/src/MathWikidataHook.php#L65 | Math hook ]]. I looked at what introduced this code. It was [[ https://github.com/wikimedia/mediawiki-extensions-Math/commit/946a18d14c21fff2251ec2cc5451b62e4df61276 | this patch ]] introduced by T67397.
The onWikibaseClientDataTypes hook is entered in both desktop and mobile for this article but the $dataTypeDefinitions['PT:math'] formatter-factory-callback is only entered on mobile. Why? I'm still investigating. I did a var_dump inside the format-factory-callback for some clues...
```
object(ValueFormatters\FormatterOptions)[868]
protected 'options' =>
array (size=11)
'languages' =>
object(Wikibase\LanguageFallbackChain)[834]
private 'chain' =>
array (size=1)
...
'lang' => string 'en' (length=2)
'on-error' => string 'warn' (length=4)
'unDeserializableMessage' => string 'wikibase-undeserializable-value' (length=31)
'geoformat' => string 'dms' (length=3)
'spacing' =>
array (size=1)
0 => string 'latlong' (length=7)
'directional' => boolean true
'forceSign' => boolean false
'showQuantityUncertaintyMargin' => boolean true
'applyRounding' => boolean true
'applyUnit' => boolean true
/vagrant/mediawiki/extensions/Math/src/MathWikidataHook.php:76:string 'text/plain' (length=10)
```
== Summary
...
TASK DETAIL
EMAIL PREFERENCES
To: Jdlrobson
Cc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Imarlier, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Winter, Vali.matei, JJMC89, Debenben, Bianjiang, Nirmos, Cwek, Wikidata-bugs, Hydriz, aude, fredw, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g
Cc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Imarlier, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Winter, Vali.matei, JJMC89, Debenben, Bianjiang, Nirmos, Cwek, Wikidata-bugs, Hydriz, aude, fredw, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
