Vvjjkkii renamed this task from "Wikibase client ApiListEntityUsage and ApiPropsEntityUsage share the same prefix 'wbeu'" to "1qaaaaaaaa".
Vvjjkkii reopened this task as "Open".
Vvjjkkii triaged this task as "High" priority.
Vvjjkkii removed subscribers: gerritbot, Aklapper.
Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, JADE, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team.
Vvjjkkii updated the task description. (Show Details)

CHANGES TO TASK DESCRIPTION
While running MediaWiki core tests with Wikibase, I eventually got a failure:
```
1) PrefixUniquenessTest::testPrefixes
Module prefix 'wbeu' is shared between Wikibase\Client\Api\ApiListEntityUsage and Wikibase\Client\Api\ApiPropsEntityUsage

tests/phpunit/includes/api/PrefixUniquenessTest.php:24
tests/phpunit/MediaWikiTestCase.php:469
maintenance/doMaintenance.php:94
```

`PrefixUniquenessTest::testPrefixes` is described as:
> Checks that all API query modules, core and extensions, have unique prefixes.


It is part of mediawiki/core, since the test is not a structure test, it is never run for extension, only for mediawiki/core patches. Which explains why it has never been noticed yet.


Related code:
```
client/includes/Api/ApiListEntityUsage.php:34: parent::__construct( $query, $moduleName, 'wbeu' );
client/includes/Api/ApiPropsEntityUsage.php:32: parent::__construct( $query, $moduleName, 'wbeu' );
```


Module references:

| Class: | ApiPropsEntityUsage | ApiListEntityUsage
|--|--|--
| Doc | https://www.mediawiki.org/wiki/Wikibase/API#wbentityusage | https://www.mediawiki.org/wiki/Wikibase/API#wblistentityusage
| Call | list=wbentityusagelist | prop=wbentityusage
| Initial commit | 382ac75c7b8cecf7ab518e5119e5cd2f1187dbc3 | c2364b8ac2ec62b74dc076129f12f0a3515b94e3
| Feature task | T143147 | T143118

26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e

TASK DETAIL
https://phabricator.wikimedia.org/T197578

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Vvjjkkii
Cc: Ladsgroup, hashar, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, herron, pan199312, GoranSMilovanovic, Adik2382, Chicocvenancio, alanajjar, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, Sethakill, Lewizho99, JJMC89, Maathavan, dg711, Jseddon, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Anomie, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, Legoktm, chasemp, gerritbot, Aklapper
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to