| Vvjjkkii renamed this task from "checkx.sh can do odd things if files contain spaces" to "h0baaaaaaa". Vvjjkkii raised the priority of this task from "Low" to "High". Vvjjkkii removed a subscriber: Aklapper. Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, JADE, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team. Vvjjkkii updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
Currently the checkx.sh script isn't safe for use on filenames with a space (or possibly newlines). This is not of zero importance because it is run by CI jobs that can be spawned by anyone making a PR.
The currently for loop isn't recommended: see http://mywiki.wooledge.org/BashPitfalls#for_i_in_.24.28ls_.2A.mp3.29
It should be rewritten to use `find -exec` or `xargs` with the `-0` option.
**Acceptance Criterion**
Given that file names contain spaces or newlines:
checkx.sh should test that whole file name without splitting
checkx.sh should not test a space or newline split fragment of the filenam26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e
The currently for loop isn't recommended: see http://mywiki.wooledge.org/BashPitfalls#for_i_in_.24.28ls_.2A.mp3.29
It should be rewritten to use `find -exec` or `xargs` with the `-0` option.
**Acceptance Criterion**
Given that file names contain spaces or newlines:
checkx.sh should test that whole file name without splitting
checkx.sh should not test a space or newline split fragment of the filenam26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e
TASK DETAIL
EMAIL PREFERENCES
To: Vvjjkkii
Cc: Tarrow, AndyTan, Zylc, 1978Gage2001, Lahi, Gq86, herron, pan199312, GoranSMilovanovic, Chicocvenancio, alanajjar, QZanden, Tbscho, Gstupp, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, JJMC89, Jseddon, Abbe98, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, revi, scfc, He7d3r, Romaine, Addshore, Mbch331, Jay8g, Glaisher, Krenair, chasemp, Aklapper
Cc: Tarrow, AndyTan, Zylc, 1978Gage2001, Lahi, Gq86, herron, pan199312, GoranSMilovanovic, Chicocvenancio, alanajjar, QZanden, Tbscho, Gstupp, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, JJMC89, Jseddon, Abbe98, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, revi, scfc, He7d3r, Romaine, Addshore, Mbch331, Jay8g, Glaisher, Krenair, chasemp, Aklapper
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
