| Vvjjkkii renamed this task from "Form ID “does not implement Int32EntityId” error in TermSqlIndex when rendering some constraint violation messages" to "a3baaaaaaa". Vvjjkkii reopened this task as "Open". Vvjjkkii triaged this task as "High" priority. Vvjjkkii removed Lucas_Werkmeister_WMDE as the assignee of this task. Vvjjkkii removed subscribers: gerritbot, Aklapper. Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, JADE, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team. Vvjjkkii updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
`TermSqlIndex` no longer uses numeric entity IDs (T188995), but it still //asserts// that entity IDs are numeric in some places, leading to unnecessary log errors like this one:
```
Entity ID: L123-F1 does not implement Int32EntityId
#0 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/TermSqlIndex.php(573): Wikibase\Lib\Store\Sql\TermSqlIndex->assertIsNumericEntityId(Wikibase\Lexeme\DataModel\FormId)
#1 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/TermSqlIndex.php(539): Wikibase\Lib\Store\Sql\TermSqlIndex->fetchTerms(array, array, array)
#2 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/BufferingTermLookup.php(139): Wikibase\Lib\Store\Sql\TermSqlIndex->getTermsOfEntities(array, array, array)
#3 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/DispatchingTermBuffer.php(87): Wikibase\Store\BufferingTermLookup->prefetchTerms(array, array, array)
#4 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/DispatchingTermBuffer.php(43): Wikibase\Lib\Store\DispatchingTermBuffer->prefetchTerms(array, array, array)
#5 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/EntityTermLookupBase.php(46): Wikibase\Lib\Store\DispatchingTermBuffer->getTermsOfType(Wikibase\Lexeme\DataModel\FormId, string, array)
#6 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/LanguageFallbackLabelDescriptionLookup.php(48): Wikibase\Lib\Store\EntityTermLookupBase->getLabels(Wikibase\Lexeme\DataModel\FormId, array)
#7 /srv/mediawiki/php-1.32.0-wmf.5/vendor/wikibase/data-model-services/src/EntityId/EntityIdLabelFormatter.php(55): Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookup->getLabel(Wikibase\Lexeme\DataModel\FormId)
#8 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Formatters/EntityIdHtmlLinkFormatter.php(64): Wikibase\DataModel\Services\EntityId\EntityIdLabelFormatter->lookupEntityLabel(Wikibase\Lexeme\DataModel\FormId)
#9 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageRenderer.php(215): Wikibase\Lib\EntityIdHtmlLinkFormatter->formatEntityId(Wikibase\Lexeme\DataModel\FormId)
#10 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageRenderer.php(142): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageRenderer->renderEntityId(Wikibase\Lexeme\DataModel\FormId, string)
#11 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageRenderer.php(85): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageRenderer->renderArgument(array)
#12 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/MultilingualTextViolationMessageRenderer.php(60): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageRenderer->render(WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessage)
#13 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/Api/CheckResultsRenderer.php(103): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\MultilingualTextViolationMessageRenderer->render(WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessage)
#14 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/Api/CheckResultsRenderer.php(65): WikibaseQuality\ConstraintReport\Api\CheckResultsRenderer->checkResultToArray(WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult)
#15 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/Api/CheckConstraints.php(266): WikibaseQuality\ConstraintReport\Api\CheckResultsRenderer->render(WikibaseQuality\ConstraintReport\ConstraintCheck\Cache\CachedCheckResults)
#16 /srv/mediawiki/php-1.32.0-wmf.5/includes/api/ApiMain.php(1579): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#17 /srv/mediawiki/php-1.32.0-wmf.5/includes/api/ApiMain.php(535): ApiMain->executeAction()
#18 /srv/mediawiki/php-1.32.0-wmf.5/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#19 /srv/mediawiki/php-1.32.0-wmf.5/api.php(83): ApiMain->execute()
#20 /srv/mediawiki/w/api.php(3): include(string)
#21 {main}
```
In this case, it happens when attempting to render a form ID in a WBQC `ViolationMessage` for a “inverse” constraint (attempting to render the form ID “L123-F1” as the expected value of the inverse statement), but I suspect it might be possible to trigger this error in some other edge cases as well.26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e
```
Entity ID: L123-F1 does not implement Int32EntityId
#0 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/TermSqlIndex.php(573): Wikibase\Lib\Store\Sql\TermSqlIndex->assertIsNumericEntityId(Wikibase\Lexeme\DataModel\FormId)
#1 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/Sql/TermSqlIndex.php(539): Wikibase\Lib\Store\Sql\TermSqlIndex->fetchTerms(array, array, array)
#2 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/BufferingTermLookup.php(139): Wikibase\Lib\Store\Sql\TermSqlIndex->getTermsOfEntities(array, array, array)
#3 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/DispatchingTermBuffer.php(87): Wikibase\Store\BufferingTermLookup->prefetchTerms(array, array, array)
#4 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/DispatchingTermBuffer.php(43): Wikibase\Lib\Store\DispatchingTermBuffer->prefetchTerms(array, array, array)
#5 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/EntityTermLookupBase.php(46): Wikibase\Lib\Store\DispatchingTermBuffer->getTermsOfType(Wikibase\Lexeme\DataModel\FormId, string, array)
#6 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Store/LanguageFallbackLabelDescriptionLookup.php(48): Wikibase\Lib\Store\EntityTermLookupBase->getLabels(Wikibase\Lexeme\DataModel\FormId, array)
#7 /srv/mediawiki/php-1.32.0-wmf.5/vendor/wikibase/data-model-services/src/EntityId/EntityIdLabelFormatter.php(55): Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookup->getLabel(Wikibase\Lexeme\DataModel\FormId)
#8 /srv/mediawiki/php-1.32.0-wmf.5/extensions/Wikibase/lib/includes/Formatters/EntityIdHtmlLinkFormatter.php(64): Wikibase\DataModel\Services\EntityId\EntityIdLabelFormatter->lookupEntityLabel(Wikibase\Lexeme\DataModel\FormId)
#9 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageRenderer.php(215): Wikibase\Lib\EntityIdHtmlLinkFormatter->formatEntityId(Wikibase\Lexeme\DataModel\FormId)
#10 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageRenderer.php(142): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageRenderer->renderEntityId(Wikibase\Lexeme\DataModel\FormId, string)
#11 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/ViolationMessageRenderer.php(85): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageRenderer->renderArgument(array)
#12 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Message/MultilingualTextViolationMessageRenderer.php(60): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessageRenderer->render(WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessage)
#13 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/Api/CheckResultsRenderer.php(103): WikibaseQuality\ConstraintReport\ConstraintCheck\Message\MultilingualTextViolationMessageRenderer->render(WikibaseQuality\ConstraintReport\ConstraintCheck\Message\ViolationMessage)
#14 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/Api/CheckResultsRenderer.php(65): WikibaseQuality\ConstraintReport\Api\CheckResultsRenderer->checkResultToArray(WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult)
#15 /srv/mediawiki/php-1.32.0-wmf.5/extensions/WikibaseQualityConstraints/src/Api/CheckConstraints.php(266): WikibaseQuality\ConstraintReport\Api\CheckResultsRenderer->render(WikibaseQuality\ConstraintReport\ConstraintCheck\Cache\CachedCheckResults)
#16 /srv/mediawiki/php-1.32.0-wmf.5/includes/api/ApiMain.php(1579): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#17 /srv/mediawiki/php-1.32.0-wmf.5/includes/api/ApiMain.php(535): ApiMain->executeAction()
#18 /srv/mediawiki/php-1.32.0-wmf.5/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#19 /srv/mediawiki/php-1.32.0-wmf.5/api.php(83): ApiMain->execute()
#20 /srv/mediawiki/w/api.php(3): include(string)
#21 {main}
```
In this case, it happens when attempting to render a form ID in a WBQC `ViolationMessage` for a “inverse” constraint (attempting to render the form ID “L123-F1” as the expected value of the inverse statement), but I suspect it might be possible to trigger this error in some other edge cases as well.26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e
TASK DETAIL
EMAIL PREFERENCES
To: Vvjjkkii
Cc: Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, herron, pan199312, GoranSMilovanovic, Adik2382, Chicocvenancio, alanajjar, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, merbst, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, Lewizho99, JJMC89, Maathavan, Jseddon, Agabi10, Ryuch, Mkdw, RuyP, JEumerus, Jonas, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Lydia_Pintscher, Darkdadaah, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, chasemp, gerritbot, Aklapper
Cc: Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, herron, pan199312, GoranSMilovanovic, Adik2382, Chicocvenancio, alanajjar, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, merbst, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, Lewizho99, JJMC89, Maathavan, Jseddon, Agabi10, Ryuch, Mkdw, RuyP, JEumerus, Jonas, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Lydia_Pintscher, Darkdadaah, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, chasemp, gerritbot, Aklapper
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
