| CommunityTechBot updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e[[ https://integration.wikimedia.org/ci/job/selenium-WikibaseLexeme-chrome/ | selenium-WikibaseLexeme-chrome ]] fails:
```
00:00:04.270 + bundle exec rake selenium
00:00:04.987 /usr/bin/ruby2.1 -S bundle exec cucumber tests/browser --backtrace --verbose --color --format pretty --format Cucumber::Formatter::Sauce --out '/srv/jenkins-workspace/workspace/selenium-WikibaseLexeme-chrome/BROWSER/chrome/MEDIAWIKI_ENVIRONMENT/beta/PLATFORM/Linux/label/DebianJessie && contintLabsSlave/log/junit' --tags ~@skip --tags @wikidata.beta.wmflabs.org --tags @chrome
00:00:06.973 no such file to load -- /srv/jenkins-workspace/workspace/selenium-WikibaseLexeme-chrome/BROWSER/chrome/MEDIAWIKI_ENVIRONMENT/beta/PLATFORM/Linux/label/DebianJessie && contintLabsSlave/tests/browser/features/support/../../../../../Wikibase/tests/browser/features/support/modules (LoadError)
```
[[ https://phabricator.wikimedia.org/diffusion/EWLE/browse/master/tests/browser/features/support/env.rb;4552f309aaf99620296491376893e4d665767e56$20-25 | WikibaseLexeme/tests/browser/features/support/env.rb:20-25 ]]
```lang=ruby
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/modules'
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/step_definitions'
require_all File.dirname(__FILE__) + '/pages'
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/utils'
require File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/pages/item_page'
require File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/pages/property_page'
```
It's a code smell if a repository just assumes another repository would be available at a precise location. If some code is shared between Wikibase and WikibaseLexeme it belongs to a library, probably mediawiki_selenium Ruby gem. If you think it's Wikibase specific maybe a new gem, mediawiki_selenium-wikibase?
```
00:00:04.270 + bundle exec rake selenium
00:00:04.987 /usr/bin/ruby2.1 -S bundle exec cucumber tests/browser --backtrace --verbose --color --format pretty --format Cucumber::Formatter::Sauce --out '/srv/jenkins-workspace/workspace/selenium-WikibaseLexeme-chrome/BROWSER/chrome/MEDIAWIKI_ENVIRONMENT/beta/PLATFORM/Linux/label/DebianJessie && contintLabsSlave/log/junit' --tags ~@skip --tags @wikidata.beta.wmflabs.org --tags @chrome
00:00:06.973 no such file to load -- /srv/jenkins-workspace/workspace/selenium-WikibaseLexeme-chrome/BROWSER/chrome/MEDIAWIKI_ENVIRONMENT/beta/PLATFORM/Linux/label/DebianJessie && contintLabsSlave/tests/browser/features/support/../../../../../Wikibase/tests/browser/features/support/modules (LoadError)
```
[[ https://phabricator.wikimedia.org/diffusion/EWLE/browse/master/tests/browser/features/support/env.rb;4552f309aaf99620296491376893e4d665767e56$20-25 | WikibaseLexeme/tests/browser/features/support/env.rb:20-25 ]]
```lang=ruby
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/modules'
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/step_definitions'
require_all File.dirname(__FILE__) + '/pages'
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/utils'
require File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/pages/item_page'
require File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/pages/property_page'
```
It's a code smell if a repository just assumes another repository would be available at a precise location. If some code is shared between Wikibase and WikibaseLexeme it belongs to a library, probably mediawiki_selenium Ruby gem. If you think it's Wikibase specific maybe a new gem, mediawiki_selenium-wikibase?
TASK DETAIL
EMAIL PREFERENCES
To: CommunityTechBot
Cc: WMDE-leszek, zeljkofilipin, Mringgaard, AndyTan, Zylc, 1978Gage2001, Lahi, Gq86, herron, GoranSMilovanovic, Chicocvenancio, alanajjar, QZanden, Tbscho, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, JJMC89, Jseddon, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Darkdadaah, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, chasemp
Cc: WMDE-leszek, zeljkofilipin, Mringgaard, AndyTan, Zylc, 1978Gage2001, Lahi, Gq86, herron, GoranSMilovanovic, Chicocvenancio, alanajjar, QZanden, Tbscho, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, JJMC89, Jseddon, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Darkdadaah, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, chasemp
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
