| CommunityTechBot updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652eWorking on Multi-Content Revisions and discussing {T190063}, it became clear that the signature and contract of Content::getSecondaryDataUpdates would no longer work for the new multi-content logic.
In particular:
* only one LinksUpdate should be generated, and it should be based on the combined ParserOutput of all slots. Havign one LinksUpdate per slot would cause them to override each other.
* DataUpdates need to be aware what slot they refer to, to enable per-slot dependency tracking, and to avoid updates from different slots from interfering with each other.
Reason for having the new method in ContentHandler:
* The signature of the method in Content cannot be changed without breaking extensions (compare {T193613})
* Following the value/service pattern, much of the functionality of the Content interface should reside in ContentHandler anyway.
In addition to the new ContentHandler::getSecondaryDataUpdates, a similar method will be needed to get all DataUpdates associated with an edit. An implementation is currently proposed in If610c68f4 in the new DerivedPageDataUpdater class, but the method should be exposed via a more narrow (provider-like) interface (see T194043).
In particular:
* only one LinksUpdate should be generated, and it should be based on the combined ParserOutput of all slots. Havign one LinksUpdate per slot would cause them to override each other.
* DataUpdates need to be aware what slot they refer to, to enable per-slot dependency tracking, and to avoid updates from different slots from interfering with each other.
Reason for having the new method in ContentHandler:
* The signature of the method in Content cannot be changed without breaking extensions (compare {T193613})
* Following the value/service pattern, much of the functionality of the Content interface should reside in ContentHandler anyway.
In addition to the new ContentHandler::getSecondaryDataUpdates, a similar method will be needed to get all DataUpdates associated with an edit. An implementation is currently proposed in If610c68f4 in the new DerivedPageDataUpdater class, but the method should be exposed via a more narrow (provider-like) interface (see T194043).
TASK DETAIL
EMAIL PREFERENCES
To: CommunityTechBot
Cc: daniel, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Bsandipan, Lordiis, herron, GoranSMilovanovic, Adik2382, Chicocvenancio, alanajjar, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, Tramullas, Acer, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, Lewizho99, JJMC89, Maathavan, Jseddon, Agabi10, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, Susannaanas, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, Aschroet, mys_721tx, Jane023, Wikidata-bugs, Snowolf, Base, matthiasmullie, aude, Huji, Gryllida, jayvdb, Ricordisamoa, Tobi_WMDE_SW, Lydia_Pintscher, Fabrice_Florin, Raymond, revi, scfc, He7d3r, Romaine, Jackmcbarn, Steinsplitter, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, chasemp
Cc: daniel, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Bsandipan, Lordiis, herron, GoranSMilovanovic, Adik2382, Chicocvenancio, alanajjar, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, Tramullas, Acer, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, Lewizho99, JJMC89, Maathavan, Jseddon, Agabi10, Ryuch, Mkdw, RuyP, JEumerus, Trizek-WMF, Susannaanas, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, Aschroet, mys_721tx, Jane023, Wikidata-bugs, Snowolf, Base, matthiasmullie, aude, Huji, Gryllida, jayvdb, Ricordisamoa, Tobi_WMDE_SW, Lydia_Pintscher, Fabrice_Florin, Raymond, revi, scfc, He7d3r, Romaine, Jackmcbarn, Steinsplitter, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, chasemp
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
