| daniel updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
Note that it may be temporarily acceptable to only support undos that do not touch multiple slotsAt present, undo simply fails if multiple slots are involved, see T194412.
Note that undo presently allows manual editing of the content to be undone. This is not possible for all kinds of content (see ContentHandler::supportsDirectEditing), see T194412and EditPage also does not currently support editing multiple slots at once.
The UX for undo operations across multiple slots needs some design workIt would probably be acceptable to not offer the ability to manually edit during an undo (check with product/UX), at least if the undo spans multiple slots. Or manual editing is only offered for the main slot - this seems ok for the SDC use case, but may be surprising when multiple slots are text based. We should at least show a warning explaining this.
* A diff for each slot should be shown for confirmation (T194731).
* A diff for each slot should be shown for confirmationIf undo supports editing, it needs to support preview! If it does not support editing, it could show a preview right away (T194731).
...
This means that the logic for undoing edits needs to be extracted from EditPage.Note that it may be temporarily acceptable to only support undos that do not touch multiple slotsAt present, undo simply fails if multiple slots are involved, see T194412.
Note that undo presently allows manual editing of the content to be undone. This is not possible for all kinds of content (see ContentHandler::supportsDirectEditing), see T194412and EditPage also does not currently support editing multiple slots at once.
The UX for undo operations across multiple slots needs some design workIt would probably be acceptable to not offer the ability to manually edit during an undo (check with product/UX), at least if the undo spans multiple slots. Or manual editing is only offered for the main slot - this seems ok for the SDC use case, but may be surprising when multiple slots are text based. We should at least show a warning explaining this.
...
* Perhaps free form editing can be dropped from the undo function completely. If we keep it, we'll need {T174033}.* A diff for each slot should be shown for confirmation (T194731).
* A diff for each slot should be shown for confirmationIf undo supports editing, it needs to support preview! If it does not support editing, it could show a preview right away (T194731).
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
Cc: CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
