Addshore added a comment.

I deployed T178652 which should hide some of the brokenness, as the locks should now only remain for 15 mins instead of an hour, but the underlying issue still remains.
I added a logger to the LockManager used for dispatching, but that hasn't logged anything yet...
Currently staring at RedisLockManager and QuorumLockManager.

While testing some stuff with eval.php if I run the following:

$lock = str_replace( ' ', '_',  "Wikibase.wikidatawiki.dispatchChanges.dewiki" );
$result = $lockManager->unlock( [ $lock ] );
var_dump( $result->__toString() );
$result = $lockManager->lock( [ $lock ] );
var_dump( $result->__toString() );

I get:

> $lock = str_replace( ' ', '_',  "Wikibase.wikidatawiki.dispatchChanges.dewiki" );

> $result = $lockManager->unlock( [ $lock ] );

> var_dump( $result->__toString() );
string(292) "<OK, collected 1 error(s) on the way, no value set>
+------+---------------------------+------------------------------------------+
|    1 | lockmanager-notlocked     | Wikibase.wikidatawiki.dispatchChanges.de |
+------+---------------------------+------------------------------------------+
"

> $result = $lockManager->lock( [ $lock ] );

> var_dump( $result->__toString() );
string(295) "<Error, collected 1 error(s) on the way, no value set>
+------+---------------------------+------------------------------------------+
|    1 | lockmanager-fail-acquirel | Wikibase.wikidatawiki.dispatchChanges.de |
+------+---------------------------+------------------------------------------+

Which seems odd, as I can neither unlock or lock the key.
If I try another key, for example "Wikibase.wikidatawiki.dispatchChanges.addshoretest" locking and locking works as expected.


TASK DETAIL
https://phabricator.wikimedia.org/T200420

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: gerritbot, Stashbot, WMDE-leszek, Addshore, TerraCodes, Liuxinyu970226, matej_suchanek, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to