matej_suchanek added a comment.

I was looking into it this morning. The problem is in StatementHtmlGenerator.php on line 100:

view/src/StatementHtmlGenerator.php
$references->isEmpty() ? '' : 'wikibase-initially-collapsed'

This makes all references initially collapsed on all views. This is achieved using CSS, which on the other hand explicitly excludes diffs and old revisions:

view/resources/wikibase/wikibase.less
.client-js body:not( .wb-diffpage ):not( .wb-oldrevpage ) .wikibase-initially-collapsed {
    display: none;
}

For T196423, we could exclude another CSS class, mw-special-Undelete. But there's no CSS class for protected pages. Note that the rendering depends on the viewing user. For some users, the references should visible as usually, for the rest, they should be inactive and visible. This needs to be considered not to break HTML caching.


TASK DETAIL
https://phabricator.wikimedia.org/T186006

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Pablo-WMDE, matej_suchanek, Lydia_Pintscher, Aklapper, Mike_Peel, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, Jrbranaa, JakeTheDeveloper, QZanden, merbst, LawExplorer, Wong128hk, Wikidata-bugs, aude, TheDJ, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to