| Lydia_Pintscher added a subscriber: Jakob_WMDE. Lydia_Pintscher added a comment. |
I just talked it through with @Jakob_WMDE.
In T199314#4455548, @Pablo-WMDE wrote:@Lydia_Pintscher Questions regarding the merging of forms - putting it in writing to reduce misunderstandings (let's see how it goes), but please let's talk
=a=
Imagine two lexemes, source and target.
Source has two forms, both have identical grammatical features, a common representation, and no contradicting representations.
Source's second form also has a statement attached to it.
Target has one form, that matches sources' both forms in grammatical features, the representation. it has no statements.How many forms will target have after the merge?
1 ) the statement from source's second form will be merged into the pre-existing target form, other forms disregarded as duplicates (strict garbage collection)
2 ) source's first form will not be disregarded, source's second form will be merged into the target form
3 ) all forms are simply applied to target (no garbage collection)
This seems to be missing the 4th option which I think we should go for. The target would have 2 Forms and one of them (second if possible but it's not really important) would have the statements.
(This assumes that option 3 means having 3 Forms in the target after merging.)
=b=
Imagine the previous example but with one form on source, two on target.
Will the merger actively remove/merge redundant forms within target?
Merging should never remove - only add or ignore if redundant. So in this example the target would have 2 Forms after merging and one of them would have statements.
Cc: Jakob_WMDE, Lydia_Pintscher, gerritbot, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
