Addshore reopened this task as "Open".
Addshore added a comment.

Re opening as this needs to be re solved as we had to stop WikibaseLexeme from running with Wikibase due to all of the recent CI issues.

My recent test with Lexeme running with Wikibase with the ContentTranslation CI produced the following: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/9972/console

16:09:26 There were 2 errors:
16:09:26 
16:09:26 1) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsWithLexemesAsTargetDisplayLemma
16:09:26 Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "foo"))
16:09:26      but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "foo"))
16:09:26 Actual html:
16:09:26 <tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="" colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="" <a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>
16:09:26 
16:09:26 /workspace/src/vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115
16:09:26 /workspace/src/vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52
16:09:26 /workspace/src/vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:29
16:09:26 /workspace/src/tests/phpunit/HamcrestPHPUnitIntegration.php:31
16:09:26 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:114
16:09:26 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
16:09:26 /workspace/src/maintenance/doMaintenance.php:94
16:09:26 
16:09:26 2) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsOnFormsTargettingFormsAreDisplayedAsLinks
16:09:26 Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "baz"))
16:09:26      but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "baz"))
16:09:26 Actual html:
16:09:26 <tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="" colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="" <a title="Lexeme:L1" href="" <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>
16:09:26 
16:09:26 /workspace/src/vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115
16:09:26 /workspace/src/vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52
16:09:26 /workspace/src/vendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:29
16:09:26 /workspace/src/tests/phpunit/HamcrestPHPUnitIntegration.php:31
16:09:26 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:448
16:09:26 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
16:09:26 /workspace/src/maintenance/doMaintenance.php:94
16:09:26 
16:09:26 FAILURES!
16:09:26 Tests: 3789, Assertions: 13750, Errors: 2, Skipped: 25.

TASK DETAIL
https://phabricator.wikimedia.org/T200508

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Stashbot, Addshore, WMDE-leszek, gerritbot, Jakob_WMDE, Aklapper, Tarrow, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, God, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331, hashar
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to