| WMDE-leszek added a comment. |
However, I wonder how this could be merged without failing tests.
That's the very good point, and I was wondering the same. It seems that Wikibase quibble/phpunit jobs do not pull in Math extension, so that code path was never reached. Will try to get this fixed (although it might, or might not be as easy to fix as it sounds).
Should I had run tests locally _with_ Math extension enabled, and not assumed CI does it (without double checking), I've had spotted the issue initially.
Why did I not see the error message when I tested the change on Jul 24th?
This I sadly cannot answer. Changes in Wikibase that resulted in the new code being incorrect are actually relatively recent, namely have been merged on July 2nd. Maybe you had a bit dated Wikibase copy or something like this?
Cc: WMDE-leszek, Agabi10, gerritbot, Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Vali.matei, Salgo60, Lewizho99, JJMC89, Maathavan, Debenben, Jonas, Bianjiang, Izno, Nirmos, Cwek, Wikidata-bugs, Hydriz, aude, fredw, Pkra, Dinoguy1000, Lydia_Pintscher, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
