| daniel added a comment. |
In T194731#4498498, @Tgr wrote:Went through the high and medium priority steps of the test plan.
- MobileFrontend diffs break (use TextSlotDiffRenderer instead of InlineDifferenceEngine). MobileFrontend hand-creates the InlineDiffRenderer so it does not get used for the main slot; I don't think the diff patch can be improved to prevent that from happening (DifferenceEngine::getSlotDiffRenderers() could check its own class and replace TextSlotDiffRenderers with itself when it's not the base class, but that's scary and would probably break way more things). It needs to be fixed in MobileFrontend (and other extensions using a similar pattern).
We'll need a ticket for that, and we need to figure out who can do this, and when.
- Diffing with non-existent old revisions is somewhat broken due to a previous patch (T201218: Viewing page's first revision via diff gives error).
How urgent is this? Do I understand correctly that this causes fatal errors when clicking certain links on the live site?
- There are a bunch of callers which pass in a content object so non-main slots get ignored (edit conflict, for example). I think that's outside scope (better to keep patches small when possible) but should be tracked and eventually converted.
I agree, but then we need a task for this. Can probably go on the MCR backlog pile, doesn't lock SDC -- unless one of these things that pass Content objects needs to work with SDC.
- I get an exception when I try to make a Wikibase slot in a non-Wikibase namespace. I think that's expected.
Hm yea, it's hard to test this before we have MediaInfo integrated with MCR. We can probably wait for that to happen, and then test that on beta.
- Couldn't figure out what "diff should reflect user language" for Wikibase means.
Wikibase diffs should be rendered in the user language. This mainly affects value rendering: labels of referenced items, number format, etc. Probably not relevant for diffs of label or description.
- Could not test VisualEditor (npm has random failures, probably because it hogs up all the memory and gets killed, and I haven't found a good way to detect or repair broken installs). Will have to test it on Beta.
ok
Cc: pmiazga, Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
