| thiemowmde added a comment. |
I just realized what this error message means: Some test (at the moment I don't know which) creates an Item, but this Item ends in code that expects a Lexeme.
One possible improvement is to let FormIdTextFormatter::formatEntityId throw an exception when the Entity returned by EntityRevisionLookup::getEntityRevision()->getEntity() is not a Form. This would give us a stack trace.
An other possible improvement is to not throw an exception, but just return $formId->getSerialization() when the EntityId is not a FormId. This would make this code work in all situations, even when the type of a property got changed from wikibase-item to wikibase-form, but the database still contains some item values that now end in the FormId formatter.
TASK DETAIL
EMAIL PREFERENCES
To: Pablo-WMDE, thiemowmde
Cc: Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
Cc: Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
