Anomie added a comment.

When hitting the first duplicate is the point. If rows A and B had the same ar_rev_id, the slots table would have been populated for A and then B would be the "first duplicate". If the deduplication decided to reassign A rather than B, we'd have the problem.

Offhand I think populateContentTables.php goes in order by ar_id while deduplicateArchiveRevId.php will wind up reassigning the row with the higher ar_id, so things will work out right anyway, but I haven't actually checked that.

A third option would be to delete the slots and content rows for just the duplicated slot_revision_ids, then deduplicate.


TASK DETAIL
https://phabricator.wikimedia.org/T202032

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: tstarling, Anomie
Cc: gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to