[Wikidata-bugs] [Maniphest] [Created] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

[Krinkle]

Krinkle created this task. Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata.

TASK DESCRIPTION

To generate the content and/or version of the mediawiki.jqueryMsg module, ResourceLoader is currently indirectly invoking the Parser.

This is adding undesirable performance overhead and generally seems like something that was likely unintentional.

It is coming from WikibaseClient's ResourceLoaderJqueryMsgModuleMagicWords hook.

Flame graph:
F25024603: Screen Shot 2018-08-16 at 21.20.03.png

Code:
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/e46b4e97f3dc87612adde85d5b2a512c49629956/client/includes/Hooks/MagicWordHookHandlers.php#126

# function doResourceLoaderJqueryMsgModuleMagicWords {
$magicWords['WBREPONAME'] = $this->getRepoName( $lang );

# function getRepoName {
$message = new Message( $repoSiteName );
$message->inLanguage( $lang );
if ( $message->exists() ) {
	return $message->parse();

TASK DETAIL

https://phabricator.wikimedia.org/T202097

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs