[Wikidata-bugs] [Maniphest] [Commented On] T202114: Wikibase Lexeme phpunit tests fail with `rev_comment` cannot be null.

Fri, 17 Aug 2018 00:46:59 -0700

Addshore added a comment.

Can (involuntarily) reproduce this locally.

Yup, local reproduction running this 1 test case seems pretty easy:

$ mw-docker-dev phpunit-file default extensions/WikibaseLexeme/tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php
Using PHP 7.1.20
PHPUnit 6.5.11 by Sebastian Bergmann and contributors.

...EE..........                                                   15 / 15 (100%)

Time: 12.43 seconds, Memory: 48.00MB

There were 2 errors:

1) Wikibase\Lexeme\Tests\MediaWiki\Specials\SpecialNewLexemeTest::testEntityIsBeingCreated_WhenValidInputIsGiven with data set "everything is set" (array('en', 'some lemma text', 'Q1', 'Q1'))
Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: INSERT  INTO `unittest_revision` (rev_page,rev_parent_id,rev_minor_edit,rev_timestamp,rev_deleted,rev_len,rev_sha1,rev_content_model,rev_content_format,rev_comment,rev_user,rev_user_text) VALUES ('2','0','0','20180817074514','0','253','hifukji6srd1qa4km3t4dan911tyw1r',NULL,NULL,NULL,'0','127.0.0.1')
Function: MediaWiki\Storage\RevisionStore::insertRevisionRowOn
Error: 1048 Column 'rev_comment' cannot be null (db-master)


/var/www/mediawiki/includes/libs/rdbms/database/Database.php:1446
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:1416
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:1186
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:2018
/var/www/mediawiki/includes/Storage/RevisionStore.php:744
/var/www/mediawiki/includes/Storage/RevisionStore.php:554
/var/www/mediawiki/includes/Storage/RevisionStore.php:495
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:3734
/var/www/mediawiki/includes/libs/rdbms/database/DBConnRef.php:49
/var/www/mediawiki/includes/libs/rdbms/database/DBConnRef.php:533
/var/www/mediawiki/includes/Storage/RevisionStore.php:497
/var/www/mediawiki/includes/Storage/PageUpdater.php:1092
/var/www/mediawiki/includes/Storage/PageUpdater.php:730
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:318
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:207
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php:87
/var/www/mediawiki/extensions/Wikibase/repo/includes/EditEntity.php:732
/var/www/mediawiki/extensions/Wikibase/repo/includes/Specials/SpecialWikibaseRepoPage.php:185
/var/www/mediawiki/extensions/Wikibase/repo/includes/Specials/SpecialNewEntity.php:161
/var/www/mediawiki/includes/htmlform/HTMLForm.php:662
/var/www/mediawiki/includes/htmlform/HTMLForm.php:554
/var/www/mediawiki/extensions/Wikibase/repo/includes/Specials/SpecialNewEntity.php:105
/var/www/mediawiki/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
/var/www/mediawiki/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
/var/www/mediawiki/tests/phpunit/includes/specials/SpecialPageTestBase.php:68
/var/www/mediawiki/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialNewEntityTestCase.php:47
/var/www/mediawiki/tests/phpunit/MediaWikiTestCase.php:475
/var/www/mediawiki/maintenance/doMaintenance.php:94

2) Wikibase\Lexeme\Tests\MediaWiki\Specials\SpecialNewLexemeTest::testEntityIsBeingCreated_WhenValidInputIsGiven with data set "using special 'mis' lemma language" (array('mis', 'some lemma text', 'Q1', 'Q1'))
Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: INSERT  INTO `unittest_revision` (rev_page,rev_parent_id,rev_minor_edit,rev_timestamp,rev_deleted,rev_len,rev_sha1,rev_content_model,rev_content_format,rev_comment,rev_user,rev_user_text) VALUES ('3','0','0','20180817074515','0','255','pmu4wnsyc0e3fh9m4thgd2iyldwktbn',NULL,NULL,NULL,'0','127.0.0.1')
Function: MediaWiki\Storage\RevisionStore::insertRevisionRowOn
Error: 1048 Column 'rev_comment' cannot be null (db-master)


/var/www/mediawiki/includes/libs/rdbms/database/Database.php:1446
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:1416
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:1186
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:2018
/var/www/mediawiki/includes/Storage/RevisionStore.php:744
/var/www/mediawiki/includes/Storage/RevisionStore.php:554
/var/www/mediawiki/includes/Storage/RevisionStore.php:495
/var/www/mediawiki/includes/libs/rdbms/database/Database.php:3734
/var/www/mediawiki/includes/libs/rdbms/database/DBConnRef.php:49
/var/www/mediawiki/includes/libs/rdbms/database/DBConnRef.php:533
/var/www/mediawiki/includes/Storage/RevisionStore.php:497
/var/www/mediawiki/includes/Storage/PageUpdater.php:1092
/var/www/mediawiki/includes/Storage/PageUpdater.php:730
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:318
/var/www/mediawiki/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:207
/var/www/mediawiki/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php:87
/var/www/mediawiki/extensions/Wikibase/repo/includes/EditEntity.php:732
/var/www/mediawiki/extensions/Wikibase/repo/includes/Specials/SpecialWikibaseRepoPage.php:185
/var/www/mediawiki/extensions/Wikibase/repo/includes/Specials/SpecialNewEntity.php:161
/var/www/mediawiki/includes/htmlform/HTMLForm.php:662
/var/www/mediawiki/includes/htmlform/HTMLForm.php:554
/var/www/mediawiki/extensions/Wikibase/repo/includes/Specials/SpecialNewEntity.php:105
/var/www/mediawiki/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
/var/www/mediawiki/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
/var/www/mediawiki/tests/phpunit/includes/specials/SpecialPageTestBase.php:68
/var/www/mediawiki/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialNewEntityTestCase.php:47
/var/www/mediawiki/tests/phpunit/MediaWikiTestCase.php:475
/var/www/mediawiki/maintenance/doMaintenance.php:94

ERRORS!
Tests: 15, Assertions: 18, Errors: 2.

TASK DETAIL
https://phabricator.wikimedia.org/T202114

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Pablo-WMDE, daniel, Addshore, TerraCodes, Liuxinyu970226, WMDE-leszek, Nikerabbit, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to