| Addshore triaged this task as "High" priority. Addshore updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
B**Outline (as reported)**
[[ https://github.com/wmde/wikibase-docker | wikibase-docker ]] builds are currently not passing because the linting is failing see: https://travis-ci.org/wmde/wikibase-docker/jobs/414313694
To fix this we can either:
- fix the rule violation: `DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments` from https://github.com/wmde/wikibase-docker/blob/master/wdqs-proxy/latest/Dockerfile#L6, See details in https://github.com/hadolint/hadolint/wiki/DL3025
- the rule could be skipped see: https://github.com/hadolint/hadolint
- I think this failure has happened (underneath us) because hadolint has introduced a new rule and we are always using the latest version of hadolint. Whether or not we should pin the hadolint version is up for debate.
** Impact and Priority**
This stops the CI running for the wikibase-docker repo and thus stops the CI for all images.
As a result changes to the images can not really be made (and have CI run) without this being fixed, thus this should be a considered a blocker for all tasks in #wikibase-containers
** Decision **
To fix this we can either fix the rule violation: `DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments` from https://github.com/wmde/wikibase-docker/blob/master/wdqs-proxy/latest/Dockerfile#L6Pin hadolint versions in the same way that we pin php code sniffer and other linters.
See details in https://github.com/hadolint/hadolint/wiki/DL3025We should either pin this to the version that we were last using, details of which can probably be extracted from T201995#4504532
OR we should fix the current linting issues and use a the alternate / name tag that is currently also used as "latest".
Or the rule could be skipped see: https://github.com/hadolint/hadolint** Tech details / pointers **
I think this failure has happened (underneath us) because hadolint has introduced a new rule and we are always using the latest version of hadolint.Linting makes up one of the 2 prebuild travis jobs https://github.com/wmde/wikibase-docker/blob/master/.travis.yml#L25
Linters are run over each image using https://github.com/wmde/wikibase-docker/blob/master/.travis/run-linters.sh
Each image is linted by hadolint indivudally https://github.com/wmde/wikibase-docker/blob/master/.travis/run-docker-linter.sh#L5
The latest version of hadolint is pulled at https://github.com/wmde/wikibase-docker/blob/master/.travis/run-linters.sh#L3 and used at https://github.com/wmde/wikibase-docker/blob/master/.travis/run-docker-linter.sh#L5
In order to use a pinned version, Whether or not wea tag should pin the hadolint version is up for debatebe added to both locations.
[[ https://github.com/wmde/wikibase-docker | wikibase-docker ]] builds are currently not passing because the linting is failing see: https://travis-ci.org/wmde/wikibase-docker/jobs/414313694
To fix this we can either:
- fix the rule violation: `DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments` from https://github.com/wmde/wikibase-docker/blob/master/wdqs-proxy/latest/Dockerfile#L6, See details in https://github.com/hadolint/hadolint/wiki/DL3025
- the rule could be skipped see: https://github.com/hadolint/hadolint
- I think this failure has happened (underneath us) because hadolint has introduced a new rule and we are always using the latest version of hadolint. Whether or not we should pin the hadolint version is up for debate.
** Impact and Priority**
This stops the CI running for the wikibase-docker repo and thus stops the CI for all images.
As a result changes to the images can not really be made (and have CI run) without this being fixed, thus this should be a considered a blocker for all tasks in #wikibase-containers
** Decision **
To fix this we can either fix the rule violation: `DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments` from https://github.com/wmde/wikibase-docker/blob/master/wdqs-proxy/latest/Dockerfile#L6Pin hadolint versions in the same way that we pin php code sniffer and other linters.
See details in https://github.com/hadolint/hadolint/wiki/DL3025We should either pin this to the version that we were last using, details of which can probably be extracted from T201995#4504532
OR we should fix the current linting issues and use a the alternate / name tag that is currently also used as "latest".
Or the rule could be skipped see: https://github.com/hadolint/hadolint** Tech details / pointers **
I think this failure has happened (underneath us) because hadolint has introduced a new rule and we are always using the latest version of hadolint.Linting makes up one of the 2 prebuild travis jobs https://github.com/wmde/wikibase-docker/blob/master/.travis.yml#L25
Linters are run over each image using https://github.com/wmde/wikibase-docker/blob/master/.travis/run-linters.sh
Each image is linted by hadolint indivudally https://github.com/wmde/wikibase-docker/blob/master/.travis/run-docker-linter.sh#L5
The latest version of hadolint is pulled at https://github.com/wmde/wikibase-docker/blob/master/.travis/run-linters.sh#L3 and used at https://github.com/wmde/wikibase-docker/blob/master/.travis/run-docker-linter.sh#L5
In order to use a pinned version, Whether or not wea tag should pin the hadolint version is up for debatebe added to both locations.
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Addshore, Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Salgo60, Abbe98, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
Cc: Addshore, Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Salgo60, Abbe98, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
