| thiemowmde updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
~~The suggestion is to **not** replace `… extends \PHPUnit_Framework_TestCase` with `… extends \PHPUnit\Framework\TestCase`, but with `… extends TestCase` and an import in the `use` section above. This fits better to the code style the Wikidata team is used to, where full qualified class names are avoided.~~
If a code base requires it's own PHPUnit version (this is the case for all PHP components that are not MediaWiki extensions), the dependency in composer.json needs to be updated like this:
...
The suggestion is to **not** care about any of these, but exclusively focus on replacing `PHPUnit_Framework_TestCase` with `TestCase`. This is the vast majority of replacements we need to do (about 84% when I count appearances in my local codebase, with the next one being 7% of `PHPUnit_Framework_MockObject_MockObject`). Focusing on this one class will make reviewing patches easier. All the other updates can be done later when actually updating to PHPUnit 6.~~The suggestion is to **not** replace `… extends \PHPUnit_Framework_TestCase` with `… extends \PHPUnit\Framework\TestCase`, but with `… extends TestCase` and an import in the `use` section above. This fits better to the code style the Wikidata team is used to, where full qualified class names are avoided.~~
If a code base requires it's own PHPUnit version (this is the case for all PHP components that are not MediaWiki extensions), the dependency in composer.json needs to be updated like this:
...
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: Addshore, Legoktm, gerritbot, Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, tabish.shaikh91, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, merbst, LawExplorer, Salgo60, TerraCodes, D3r1ck01, MuhammadShuaib, Izno, SimmeD, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, TheDJ, Mbch331, Jay8g
Cc: Addshore, Legoktm, gerritbot, Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, tabish.shaikh91, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, merbst, LawExplorer, Salgo60, TerraCodes, D3r1ck01, MuhammadShuaib, Izno, SimmeD, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, TheDJ, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
