| Addshore triaged this task as "Low" priority. Addshore updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
# TODOAs a wikibase developer I want to use the nodejs test framework so that I only have 1 selenium test framework to think about.
As the WMF I want to use the nodejs test framework in wikibaselexeme so that all wmf deployed extensions are consistent.
As release engineering I want to remove all ruby selenium jobs so that more CI time is available for other jobs.
**Details**
# Jenkins jobs to setup
[x] mediawiki/core: master: Selenium: run Wikibase repo tests [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441051 | 441051 ]]
[x] integration/config: master: Run qunit-selenium Jenkins job for Wikibase [[ https://gerrit.wikimedia.org/r/c/integration/config/+/441195 | 441195 ]]
[x] mediawiki/extensions/Wikibase: master: Start a very basic nodejs browser test [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/438000 | 438000 ]]
# Features to migrate
[] aliases.feature
[] authority_control_gadget.feature
[] delete_item.feature
[] description.feature
[] edit_tab.feature
[] empty_label_and_description.feature
[] header.feature
[] item_smoke.feature
[] label.feature
[] non_existing_item.feature
[] property_smoke.feature
[] reference.feature
[] sitelinks.feature
[] sitelinks_badge.feature
[] special_set_label.feature
[] statement.feature
[] statements_geo.feature
[] statements_item.feature
[] statements_monolingual.feature
[] statements_quantity.feature
[] statements_rank.feature
[] statements_snaktype.feature
[] statements_string.feature
[] statements_time.feature
[] statements_url.feature
**Impact & Priority**
There is no specific point in time when the migration should happen (i.e. does not have happen immediately).
The WMDE is no longer supporting the ruby framework so if it does break we will be on our own and then forced to make fixes / migrate before Wikibase development can continue.
The ruby tests do not run as part of the mediawiki core gate-submit jobs, although the node ones will. Having our tests run with the core gets submit tests will eliminate breakages caused by core changes.
**Task**
Convert all ruby features to be run as part of the node JS selenium tests.
A test framework example can probably be taken from WikibaseLexeme which already includes node browser tests.
# Done**Acceptance Criteria**
🏝 mediawiki/core: master: Selenium: run Wikibase repo tests [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441051 | 441051 ]] - No ruby test features exist in the Wikibase git repo code base
- All features that did exist have been converted to the node js system
🏝 integration/config: master: Run qunit-selenium Jenkins job for Wikibase [[ https://gerrit.wikimedia.org/r/c/integration/config/+/441195 | 441195 ]] - The "mwext-mw-selenium-composer-jessie" jenkins job that runs on Wikibase git code changes in gate-submit no longer runs on them
🏝 mediawiki/extensions/Wikibase: master: Start a very basic nodejs browser test [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/438000 | 438000 ]] - All other files & docs relating to the ruby tests have been removed from the Wikibase git repo
As the WMF I want to use the nodejs test framework in wikibaselexeme so that all wmf deployed extensions are consistent.
As release engineering I want to remove all ruby selenium jobs so that more CI time is available for other jobs.
**Details**
# Jenkins jobs to setup
[x] mediawiki/core: master: Selenium: run Wikibase repo tests [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441051 | 441051 ]]
[x] integration/config: master: Run qunit-selenium Jenkins job for Wikibase [[ https://gerrit.wikimedia.org/r/c/integration/config/+/441195 | 441195 ]]
[x] mediawiki/extensions/Wikibase: master: Start a very basic nodejs browser test [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/438000 | 438000 ]]
# Features to migrate
[] aliases.feature
[] authority_control_gadget.feature
[] delete_item.feature
[] description.feature
[] edit_tab.feature
[] empty_label_and_description.feature
[] header.feature
[] item_smoke.feature
[] label.feature
[] non_existing_item.feature
[] property_smoke.feature
[] reference.feature
[] sitelinks.feature
[] sitelinks_badge.feature
[] special_set_label.feature
[] statement.feature
[] statements_geo.feature
[] statements_item.feature
[] statements_monolingual.feature
[] statements_quantity.feature
[] statements_rank.feature
[] statements_snaktype.feature
[] statements_string.feature
[] statements_time.feature
[] statements_url.feature
**Impact & Priority**
There is no specific point in time when the migration should happen (i.e. does not have happen immediately).
The WMDE is no longer supporting the ruby framework so if it does break we will be on our own and then forced to make fixes / migrate before Wikibase development can continue.
The ruby tests do not run as part of the mediawiki core gate-submit jobs, although the node ones will. Having our tests run with the core gets submit tests will eliminate breakages caused by core changes.
**Task**
Convert all ruby features to be run as part of the node JS selenium tests.
A test framework example can probably be taken from WikibaseLexeme which already includes node browser tests.
# Done**Acceptance Criteria**
🏝 mediawiki/core: master: Selenium: run Wikibase repo tests [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441051 | 441051 ]] - No ruby test features exist in the Wikibase git repo code base
- All features that did exist have been converted to the node js system
🏝 integration/config: master: Run qunit-selenium Jenkins job for Wikibase [[ https://gerrit.wikimedia.org/r/c/integration/config/+/441195 | 441195 ]] - The "mwext-mw-selenium-composer-jessie" jenkins job that runs on Wikibase git code changes in gate-submit no longer runs on them
🏝 mediawiki/extensions/Wikibase: master: Start a very basic nodejs browser test [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/438000 | 438000 ]] - All other files & docs relating to the ruby tests have been removed from the Wikibase git repo
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Ladsgroup, gerritbot, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Salgo60, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
Cc: Ladsgroup, gerritbot, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Salgo60, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
