| Marostegui added a comment. |
In T197854#4512107, @Addshore wrote:Should we push forward with the rename or should we add it to our code base with the name "tmp1" for now?
I would add it to code base for now. Add it as tmp1 for now to at least reflect what we have in production and then continue with T194273
If we want to push forward with the rename do we need a decision on the name?
We'd need a decision on the name + check if the index usage isn't hardcoded in any query FOCE INDEX (tmp1) + change it in our table codebase definition + an alter table that can take some weeks (given the size of the table).
Is the decision on the name & adding it to code the thing blocking moving forward with this ticket?
I think this ticket is somewhat a duplicate or related to T194273, if the idea is to eventually get rid of it I think we should only go for the change in wikibase.sql and avoid altering the table for weeks as it will be eventually dropped.
If we are not going to invest time on T194273 and want to keep tmp1 then we'd need to:
- close task T194273
- check if tmp1 index is harcoded somewhere in the code.
- decide an index name for tmp1
- change it on wikibase.sql to reflect the new index name
- alter wb_terms in production.
Cc: Addshore, Ladsgroup, Aklapper, Marostegui, WMDE-leszek, AndyTan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Minhnv-2809, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
