| tstarling added a comment. |
BlobStoreFactory has a single LoadBalancer injected into its constructor, but allows the caller to choose the wiki ID in newSqlBlobStore(). So that's wrong. Wikidata just gets the BlobStoreFactory from MediaWikiServices::getBlobStoreFactory(), which doesn't allow you to specify the wiki ID and just gives a BlobStoreFactory with the LoadBalancer for the current wiki. BlobStoreFactory could take an LBFactory instead, which would allow newSqlBlobStore() to fetch the correct LoadBalancer.
TASK DETAIL
EMAIL PREFERENCES
To: tstarling
Cc: Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair
Cc: Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
