Addshore added a comment.

It looks like WikiPageEntityRevisionLookup::getEntityRevision is passed LATEST_FROM_MASTER while merging.
However this is not passed in any way into WikiPageEntityRevisionLookup::loadEntity
So when that method interacts with RevisionStore it does not pass any special flags and thus a replica can be used.

The fix is probably to pass information about if a the master or a replica etc should be used into WikiPageEntityRevisionLookup::loadEntity


TASK DETAIL
https://phabricator.wikimedia.org/T202706

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: gerritbot, daniel, Addshore, Aklapper, Bugreporter, stebsco, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to