View Revision
Lucas_Werkmeister_WMDE edited the summary of this revision. (Show Details)

CHANGES TO REVISION SUMMARY
Canonical Decomposition is not the form of strings used by Wikibase (Wikibase uses Canonical Composition), and it is not usually the form in which user input is received ([some browsers][1](https://stackoverflow.com/a/11190012) explicitly normalize inputs to Canonical Composition, and other input is also usually in a normalized form), so if we only Decompose one half of the values when comparing them, we will usually end up reporting a mismatch. This manifests itself as an error (“base statement not found”) when attempting to add a statement with qualifiers whose value contains
...
The fix for this is simple: normalize both sides when comparing strings. In that case, it also doesn’t matter which normalization form we use.

[1]: https://stackoverflow.com/a/11190012

REPOSITORY
R2010 tool-quickstatements

CHANGES SINCE LAST ACTION
https://phabricator.wikimedia.org/D1105/new/

REVISION DETAIL
https://phabricator.wikimedia.org/D1105

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Magnus
Cc: Magnus, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to