| Pablo-WMDE renamed this task from "h1 should only contain phrasing content in Wikidata lexeme pages" to "Lemmas widget: HTML validity". Pablo-WMDE updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
HTML headings (`<h*>`) should only have [[ https://www.w3.org/TR/2014/REC-html5-20141028/dom.html#phrasing-content | phrasing content ]].The HTML structure of lexeme pages should contais only well-organized elements. Mediawiki provides us with a skeleton for most parts of the page. Amongst these is an HTML element for the primary title of a page, However,`.firstHeading` - being an `h1` tag. this is everything that `h1` contains ([[ http://www.wikidata.org/entity/L2 | L2 ]]):Currently the lexeme page provides another `h1` with invalid mark-up (not only [[ https://www.w3.org/TR/2014/REC-html5-20141028/dom.html#phrasing-content | phrasing content ]]).
```**AC**
* the default mediawiki h1 contains all lemmas, well marked-up including language and directionality
<h1 id="wb-lexeme-header-lemmas"><div class="wb-lexeme-header_id">(L2)</div> <div class="wb-lexeme-header_lemma-widget"><div class="lemma-widget"><ul class="lemma-widget_lemma-list"><li class="lemma-widget_lemma"><span class="lemma-widget_lemma-value">first</span> <span class="lemma-widget_lemma-language">en</span></li></ul></div></div> <div class="lemma-widget_controls"><button type="button" class="lemma-widget_edit">edit</button> <!----> <!----></div></h1>* the default mediawiki h1 is not visible
```* `#wb-lexeme-header-lemmas` uses a `div` instead of an `h1` tag
This makes the HTML document invalid and can confuse some search engines. The HTML structure of lexeme pages should be modified so that `h1` contains only well-organized [[ https://www.w3.org/TR/2014/REC-html5-20141028/dom.html#phrasing-content | phrasing content ]]**Info**
* this was researched in T199081 - see when addressing the rendering of the lemmas into the default mediawiki h1
* The h1 in the Lexeme header also causes some styles to be applied (e.g. Note that `span` tags are valid phrasing content.serif font) which will be resolved this way
The h1 in the Lexeme header also causes some styles to be applied (e.g. serif font) which may or may not be desired for some parts of it.* lemma hyphenation is addressed in T203242
```**AC**
* the default mediawiki h1 contains all lemmas, well marked-up including language and directionality
<h1 id="wb-lexeme-header-lemmas"><div class="wb-lexeme-header_id">(L2)</div> <div class="wb-lexeme-header_lemma-widget"><div class="lemma-widget"><ul class="lemma-widget_lemma-list"><li class="lemma-widget_lemma"><span class="lemma-widget_lemma-value">first</span> <span class="lemma-widget_lemma-language">en</span></li></ul></div></div> <div class="lemma-widget_controls"><button type="button" class="lemma-widget_edit">edit</button> <!----> <!----></div></h1>* the default mediawiki h1 is not visible
```* `#wb-lexeme-header-lemmas` uses a `div` instead of an `h1` tag
This makes the HTML document invalid and can confuse some search engines. The HTML structure of lexeme pages should be modified so that `h1` contains only well-organized [[ https://www.w3.org/TR/2014/REC-html5-20141028/dom.html#phrasing-content | phrasing content ]]**Info**
* this was researched in T199081 - see when addressing the rendering of the lemmas into the default mediawiki h1
* The h1 in the Lexeme header also causes some styles to be applied (e.g. Note that `span` tags are valid phrasing content.serif font) which will be resolved this way
The h1 in the Lexeme header also causes some styles to be applied (e.g. serif font) which may or may not be desired for some parts of it.* lemma hyphenation is addressed in T203242
TASK DETAIL
EMAIL PREFERENCES
To: Pablo-WMDE
Cc: Pablo-WMDE, abian, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
Cc: Pablo-WMDE, abian, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
