daniel added a comment.
In EntityContent::getDiff(), we have:
```
$redirectDiffOps = $differ->doDiff(
$fromContent->getRedirectData(),
$toContent->getRedirectData()
);
```
As you noted, getRedirectData() returns an array representation of the
redirects, and $differ->doDiff() operates directly on them. This logic is
trivial, but still does not belong into EntityContent. There should be an
EntityContentDiffer encapsulating all that nastiness;
Furthermore, EntityContentDiffer should also implement the logic in
getPatchedCopy(); then, EntityContent would no longer need getRedirectData(),
which would then be moved to EntityContentDiffer, which would then encapsulate
the knowledge about how redirects are diffed and patched.
TASK DETAIL
https://phabricator.wikimedia.org/T69238
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
<username>.
To: daniel
Cc: Lydia_Pintscher, daniel, GPHemsley, Wikidata-bugs, aude
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
