| Addshore added a comment. |
I think there is an improvement to be made in Wikibase\EntityContent::collectValues.
it currently has a hard coded list of keys to ignore:
//XXX: $ignore contains knowledge about the Entity's internal representation. // This list should therefore rather be maintained in the Entity class. static $ignore = [ 'language', 'site', 'type', ];
This should be provided by each entity type as they can be different.
For regular items and properties there are keys missing that should be added.
For lexeme etc there are other keys that possible need to be added / thought about that have no way of getting into that list.Ignoring more keys here will result in less data for AbuseFilter to then run through which would increase performance...
Right now for example the AbuseFilter will get handed all of the reference hashes and snak types etc.
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Addshore, Krinkle, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
Cc: Addshore, Krinkle, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
