nray added a comment.

Is there any existing extension that does this already?

Google Rich Cards is the closest one I can find.

Should this live in the Google Rich Cards extension?

Pros: Already setup as an extension that outputs json-ld. Has well-defined responsibilities.
Cons: Looks like it does not currently support the 'sameAs' property. Currently adds script to head which would block. May include more schema.org attributes then desired.

Should it be a gadget?

Pros: Fast to setup
Cons: Adds json-ld script dynamically (through _javascript_) which may cause readability issues in search engines other than Google. Would need to enable on a per wiki basis. Could this be toggled on/off by users and affect search engine efficacy?

Should it live in a Wikibase extension? Which one?

Lydia from Wikidata team has said it might be able to go into the Wikibase Client extension. Seeking an opinion from @Addshore on how viable this would be.

Pros: The code relies on wikibase item data set by wikibase client so it might be more convenient to put it in the same codebase with a feature flag rather than creating a new extension that depends on Wikibase Client. Wikibase extension has already been setup and is used in many wikis.
Cons: Is this making the Wikibase Client do too much?

Should it live in MobileFrontend?

Assuming we want the json-ld to be in mobile and desktop sites, I don't see this as a viable option.

Should it live in core?

Pros: Nothing immediate comes to mind
Cons: Probably asking core to do too much / not a responsibility of core

Should it live in its own extension? If so does it need security review?

Pros: Could be an extension with well-defined and singular responsibilities outputting json-ld with the exact attributes we want.
Cons: Would need to "start from scratch" making an extension and might be time-intensive. Seeking clarification from security team on whether this would need a security review.


TASK DETAIL
https://phabricator.wikimedia.org/T204070

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: nray
Cc: Lydia_Pintscher, Addshore, Deskana, Aklapper, Krenair, cscott, Imarlier, dr0ptp4kt, phuedx, Niedzielski, CKoerner_WMF, Elitre, Tbayer, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to