Tarrow added a comment. |
I believe now that https://gerrit.wikimedia.org/r/459505 is merged we can go ahead.
Jonas' -2
We need to first teach the hook to evaluate ranking information, otherwise we have a running condition that randomly sorts suggestions.
is, I believe, satisfied by the above patch. Since @Jonas is now hiking and also away I'm going to go ahead and remove the -2.
I have tested it locally and am happy that in my dev setup that the suggestions are sorted by rank
TASK DETAIL
EMAIL PREFERENCES
To: Jonas, Tarrow
Cc: Tarrow, hoo, gerritbot, Aklapper, Jonas, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
Cc: Tarrow, hoo, gerritbot, Aklapper, Jonas, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs