| Halfak added a comment. |
For clarity, I was originally advocating that we didn't combine any hashes and that instead we provided a <sha1> tag in each of the <content> slots. I now see that we're going to make a mess in favor of backwards compatibility. So there will continue to be a <sha1> tag and <text> at the top of the <revision> tree anyway. (Note that this now differs from the mwapi structure that is forcing everything into "content" and throwing loud warnings if you expect text to appear where it used to be). In that case, I'd like the structure of the mediawiki database to be reflected here. E.g. <revision>'s <sha1> should reflect the rev_sha1 field.
As for the sha1 of the main slot (<revision>'s <text>), I don't have a strong opinion. Attributes and tags require the same code complexity to deal with when processing the XML dumps. If you decide on a tag, I do think that "content-sha1" is needlessly ambiguous. It could be "text-sha1" to reflect the name of the <text> tag or maybe "main-sha1" to reflect the concept of the "main slot".
Cc: mako, FaFlo, Halfak, vrandezo, Denny, kchapman, tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, Agabi10, D3r1ck01, SBisson, gnosygnu, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
