hashar added a comment.

The Quibble jobs now report again junit xml files (T207841) which offers a way to compare the tests that have been run.

I went with a recheck of a dummy Wikibase change (Gerrit #70395) and compared the testcase names for three jobs:

Job namePHPUnit command
mwext-Wikibase-repo-tests-sqlite-hhvm-jessiephpunit --group Wikibase,WikibaseAPI,Purtle
mwext-Wikibase-client-tests-mysql-hhvm-jessiephpunit --group Wikibase,WikibaseClient
quibble-vendor-mysql-hhvm-dockerphpunit --testsuite extensions

The Quibble jobs runs everything, when the Wikibase jobs run only a subset of tests based on groups.

I then downloaded the Junit XML files then extracted the test names with grep -P -o 'name=".*?"' to compare the tests being run.

All tests from the client job are run.

For the repo flavor, I have the following extra tests:

-name="testErrorBeingDisplayed_WhenItemWithTheSameLabelAndDescriptionInThisLanguageAlreadyExists"
-name="testGetLabelWithDescriptionConflicts_NoUseSearchFields with data set "by label and description, different description capitalization""
-name="testGetLabelWithDescriptionConflicts_NoUseSearchFields with data set "by label and description, different label capitalization""
-name="testGetLabelWithDescriptionConflicts_NoUseSearchFields with data set "by label and description""
-name="testGetLabelWithDescriptionConflicts_NoUseSearchFields with data set "by label, empty descriptions""
-name="testGetLabelWithDescriptionConflicts_NoUseSearchFields with data set "by label, mismatching description""
-name="testGetLabelWithDescriptionConflicts_NoUseSearchFields with data set "two languages for label and description""
-name="testGetLabelWithDescriptionConflicts with data set "by label and description, different description capitalization""
-name="testGetLabelWithDescriptionConflicts with data set "by label and description, different label capitalization""
-name="testGetLabelWithDescriptionConflicts with data set "by label and description""
-name="testGetLabelWithDescriptionConflicts with data set "by label, empty descriptions""
-name="testGetLabelWithDescriptionConflicts with data set "by label, mismatching description""
-name="testGetLabelWithDescriptionConflicts with data set "two languages for label and description""
-name="testItemLabelDescriptionConflict"
-name="testReallyDoQuery"

The repo job runs with MySQL, all five tests are explicitly skipped when running on MySQL, notably because it does not allow self-joins on temporary tables.

So I think we can safely remove the legacy jobs mwext-Wikibase-repo-tests-sqlite-hhvm-jessie and mwext-Wikibase-client-tests-mysql-hhvm-jessie .


TASK DETAIL
https://phabricator.wikimedia.org/T188717

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: gerritbot, hashar, Pablo-WMDE, Addshore, WMDE-leszek, Legoktm, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, God, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to