| Pablo-WMDE added a comment. |
Random observations I'd like to discuss before we call this:
- id="app" on the vue root element needs to change - in theory this is bigger than "termbox" as the actual termbox component is a (currently only) child of it. How about wikibase-vue-view for starters? I'm also tempted to leave the technology out of it but I think it's ok for it to be "special" for the moment.
- data-server-rendered=true is very handy indeed to quickly tell if HTML was produced on the server side. Should we add another / remove this data attribute when (re)drawing on the client side?
- apparently the CSS for ".termbox-placeholder" does not come into effect when looking at wikibase including the SSR result w/o JS, i.e. it's not a grey box.
TASK DETAIL
EMAIL PREFERENCES
To: Pablo-WMDE
Cc: Pablo-WMDE, Matthias_Geisler_WMDE, Lea_WMDE, Aklapper, Jonas, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
Cc: Pablo-WMDE, Matthias_Geisler_WMDE, Lea_WMDE, Aklapper, Jonas, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
