Lucas_Werkmeister_WMDE added a comment.

The actual location of the error (PHP excludes it from the stack trace for reasons that escape me):

/srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/ContemporaryChecker.php:114

This corresponds to the $objectStatements assignment here:

		/** @var EntityId $subjectId */
		$subjectId = $context->getEntity()->getId();
		/** @var EntityId $objectId */
		$objectId = $snak->getDataValue()->getEntityId();
		/** @var Statement[] $subjectStatements */
		$subjectStatements = $context->getEntity()->getStatements()->toArray();
		/** @var Statement[] $objectStatements */
		$objectStatements = $this->entityLookup->getEntity( $objectId )->getStatements()->toArray();
		/** @var String[] $startPropertyIds */
		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
		/** @var String[] $endPropertyIds */
		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );

In this case, the object item has actually been deleted, which is not supposed to happen on Wikidata (items should only be deleted if they’re not used) but isn’t prevented on a technical level, so I guess ContemporaryChecker needs to guard against it. (If I recall correctly, several other checkers already include such guards.)


TASK DETAIL
https://phabricator.wikimedia.org/T208918

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Krinkle, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to