Addshore added a comment.

So, from the discussion I had in #wikimedia-editing on IRC: (a rough summary)

11:49 AM <addshore> Hi again edsanders :D Does mediawiki have one of these? https://eslint.org/docs/developer-guide/shareable-configs
11:50 AM <addshore> basically we want to use https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/463464/2/.eslintrc.json@146 in wikibase, without copy and pasting it into our own file
12:28 PM <+edsanders> addshore: yes, and you're using it :)
12:28 PM <+edsanders> https://github.com/wikimedia/eslint-config-wikimedia
12:29 PM <addshore> Aaahhh :)
12:29 PM <+edsanders> we want to upstream those no-restrict-properties rules in core
12:30 PM <+edsanders> but no-restricted-properties isn't eh best way to do it
12:30 PM <+edsanders> (mainly because they all throw the same exception)
12:30 PM <addshore> Is there a ticket tracking this stuff? :)
12:32 PM <addshore> Even if it's not the best way, we could still upstream it? ;)
12:33 PM <addshore> Otherwise we are just going to end up duplicating that bit list into Wikibase ;)
12:36 PM <+edsanders> yeah - I meant you to file an issue on that github repo
12:36 PM <+edsanders> *I mean to file
12:36 PM <+edsanders> * I meant to file
12:36 PM <+edsanders> I can't type today
12:36 PM <+edsanders> there was some discussion on the patch that introduced those rules in core
12:38 PM <+edsanders> oh wait, you already linked to that patch
12:38 PM <+edsanders> I'll file
12:39 PM <+edsanders> https://github.com/wikimedia/eslint-config-wikimedia/issues/113
12:56 PM <+MatmaRex> edsanders: addshore: that is still not merged btw. so you could merge it :)
1:07 PM <addshore> Oh....
1:07 PM <addshore> Hahhaaa
1:15 PM <addshore> Who technically owns that repo on GitHub? As in who decides if it goes in?


TASK DETAIL
https://phabricator.wikimedia.org/T207169

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Addshore
Cc: matmarex, gerritbot, WMDE-leszek, Jakob_WMDE, Pablo-WMDE, Matthias_Geisler_WMDE, Addshore, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to